Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated pkg_resources #68

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Replace deprecated pkg_resources #68

merged 1 commit into from
Aug 19, 2024

Conversation

magnusuMET
Copy link
Contributor

@magnusuMET magnusuMET commented Aug 19, 2024 •
edited by thorbjoernl
Loading

Change Summary

Replaces pkg_resources with importlib.metadata

Related issue number

pkg_resources is not available on newer python versions

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl
Copy link
Collaborator

Thanks!

thorbjoernl
thorbjoernl approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thorbjoernl thorbjoernl merged commit 6beb301 into metno:main Aug 19, 2024
2 checks passed
@magnusuMET magnusuMET deleted the bugfix/pkg_resources branch August 19, 2024 13:28
@thorbjoernl thorbjoernl mentioned this pull request Aug 27, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorbjoernl thorbjoernl thorbjoernl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusuMET @thorbjoernl