Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Enable hard delete by param #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Alva8756
Copy link
Contributor

It looks like we already support hard-delete but it's disabled by default.

Maybe we can use param to enable hard-delete. Existing behavior remain unchanged if there is no param.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9089164) 72.72% compared to head (e61bfc2) 72.70%.

Files Patch % Lines
pkg/api/v1/server_service.go 0.00% 2 Missing ⚠️
pkg/api/v1/router_server.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   72.72%   72.70%   -0.03%     
==========================================
  Files          38       38              
  Lines        3733     3737       +4     
==========================================
+ Hits         2715     2717       +2     
- Misses        760      762       +2     
  Partials      258      258              
Flag Coverage Δ
unittests 72.70% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant