client: add method to enable dumping http request/response #184
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponses Setting a io.Writer which could be a os.Stdout/os.Stderr or a file handle, would result in the serverservice client dumping http request, responses for debugging.
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 71.27% 70.56% -0.71%
==========================================
Files 35 35
Lines 3380 3414 +34
==========================================
Hits 2409 2409
- Misses 721 753 +32
- Partials 250 252 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JAORMX
reviewed
Dec 21, 2022
| // SetDumper sets requests and responses to be written to the given writer for debugging. | ||
| func (c *Client) SetDumper(w io.Writer) { | ||
| c.dumper = w | ||
| } |
There was a problem hiding this comment.
uhm... the client already wraps the http client with the Doer interface in this file at line 23. Why not write a wrapper around that instead of adding direct calls to the dumper?
There was a problem hiding this comment.
apologies, I haven't responded here sooner - I'll be testing this suggestion out to see if it works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
SetDumper()method on the serverservice client to enable debugging http requests and responses.SetDumper can be given a
io.Writerwhich could be a os.Stdout/os.Stderr or a file handle, when anio.Writeris set, it would result in the serverservice client writing the http request, responses for debugging.