Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shapes definition #5923

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Refactor shapes definition #5923

wants to merge 8 commits into from

Conversation

sidharthv96
Copy link
Member

📑 Summary

Organizes the shapes definition, so that we can utilize it better.

📏 Design Decisions

The new structure allows us to have a single source of truth for the shape data. This can be used to auto generate documentation, tests etc.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: d9a26ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d9a26ff
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66ffb1fa16c2ac0008f65cf7
😎 Deploy Preview https://deploy-preview-5923--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 3, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5923
pnpm add https://pkg.pr.new/mermaid-js/mermaid@5923
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5923
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5923

commit: d9a26ff

Copy link

argos-ci bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Oct 4, 2024, 9:24 AM

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 517 lines in your changes missing coverage. Please review.

Project coverage is 4.65%. Comparing base (ddf18dd) to head (d9a26ff).

Files with missing lines Patch % Lines
...id/src/rendering-util/rendering-elements/shapes.ts 0.00% 475 Missing ⚠️
...aid/src/rendering-util/rendering-elements/nodes.js 0.00% 8 Missing ⚠️
...rendering-util/rendering-elements/shapes/anchor.ts 0.00% 1 Missing ⚠️
...ering-util/rendering-elements/shapes/bowTieRect.ts 0.00% 1 Missing ⚠️
...c/rendering-util/rendering-elements/shapes/card.ts 0.00% 1 Missing ⚠️
...ng-util/rendering-elements/shapes/crossedCircle.ts 0.00% 1 Missing ⚠️
...g-util/rendering-elements/shapes/curlyBraceLeft.ts 0.00% 1 Missing ⚠️
...-util/rendering-elements/shapes/curlyBraceRight.ts 0.00% 1 Missing ⚠️
...ring-util/rendering-elements/shapes/curlyBraces.ts 0.00% 1 Missing ⚠️
...-util/rendering-elements/shapes/curvedTrapezoid.ts 0.00% 1 Missing ⚠️
... and 26 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5923      +/-   ##
==========================================
- Coverage     4.67%   4.65%   -0.02%     
==========================================
  Files          372     374       +2     
  Lines        51669   51857     +188     
  Branches       611     587      -24     
==========================================
  Hits          2414    2414              
- Misses       49255   49443     +188     
Flag Coverage Δ
unit 4.65% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rendering-util/rendering-elements/shapes/anchor.ts 0.00% <0.00%> (ø)
...ering-util/rendering-elements/shapes/bowTieRect.ts 0.00% <0.00%> (ø)
...c/rendering-util/rendering-elements/shapes/card.ts 0.00% <0.00%> (ø)
...ng-util/rendering-elements/shapes/crossedCircle.ts 0.00% <0.00%> (ø)
...g-util/rendering-elements/shapes/curlyBraceLeft.ts 0.00% <0.00%> (ø)
...-util/rendering-elements/shapes/curlyBraceRight.ts 0.00% <0.00%> (ø)
...ring-util/rendering-elements/shapes/curlyBraces.ts 0.00% <0.00%> (ø)
...-util/rendering-elements/shapes/curvedTrapezoid.ts 0.00% <0.00%> (ø)
...ring-util/rendering-elements/shapes/dividedRect.ts 0.00% <0.00%> (ø)
...ndering-util/rendering-elements/shapes/document.ts 0.00% <0.00%> (ø)
... and 26 more

... and 1 file with indirect coverage changes

* develop:
  fix: Hard code handDrawnSeed
* develop:
  chore: move handDrawnSeed to mermaidUrl function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants