Fix highlight #5903
Fix highlight #5903
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
| ```mermaid | ||
| zenuml | ||
| Alice->Bob: Hello Bob, how are you? | ||
| Bob->Alice: Not so good :( | ||
| opt { | ||
| Bob->Alice: Thanks for asking | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
The mermaid code is present for github to render the diagram, and the mermaid-example is present to show the code. Please don't remove the mermaid blocks.
There was a problem hiding this comment.
I intended to only change the mermaid-example to mmd.
but the highliht is still not working, I changed this to draft for now.
There was a problem hiding this comment.
openned an issue to solve the problem. shikijs/textmate-grammars-themes#93
📑 Summary
fix lack of code highlight
📏 Design Decisions
mermaid-example is bad as an alias for mermaid language highligth as reviewer by the shiki maintainer. Using mmd instead.
📋 Tasks
🚧 This only changes de docs so I didn't run the tests and building process!
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.