Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Model Diagram #5861

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

schicks
Copy link

@schicks schicks commented Sep 14, 2024

📑 Summary

Implements an event model diagram. Creating this PR early to make sure I'm not going off in some ridiculous direction, given that I haven't contributed here before.

Resolves #5860

📏 Design Decisions

Trying to follow the steps here as closely as possible. The grammar is taken from my high level description in the issue thread.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Sep 14, 2024

⚠️ No Changeset found

Latest commit: 3b234ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Enhancement New feature or request label Sep 14, 2024
Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 3b234ac
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66f1bb1782dad50008cd273d

Copy link

pkg-pr-new bot commented Sep 14, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5861
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5861
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5861
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5861

commit: 61a73ca

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 4.99%. Comparing base (17c6ed6) to head (3f96c9e).

Files with missing lines Patch % Lines
packages/parser/src/language/eventModel/module.ts 0.00% 51 Missing ⚠️
packages/parser/src/parse.ts 0.00% 8 Missing ⚠️
packages/parser/src/language/index.ts 0.00% 3 Missing ⚠️
packages/parser/src/language/eventModel/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5861      +/-   ##
==========================================
- Coverage     5.00%   4.99%   -0.01%     
==========================================
  Files          338     340       +2     
  Lines        48221   48282      +61     
  Branches       551     553       +2     
==========================================
  Hits          2413    2413              
- Misses       45808   45869      +61     
Flag Coverage Δ
unit 4.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/parser/src/language/eventModel/index.ts 0.00% <0.00%> (ø)
packages/parser/src/language/index.ts 0.00% <0.00%> (ø)
packages/parser/src/parse.ts 0.00% <0.00%> (ø)
packages/parser/src/language/eventModel/module.ts 0.00% <0.00%> (ø)

Copy link

argos-ci bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Modeling Diagram
1 participant