Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /lib/firmware to search path #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

piggz
Copy link

@piggz piggz commented Apr 7, 2022

In early boot, the other locations may not be mounted, so its useful to also search a path on the root filesystem

In early boot, the other locations may not be mounted, so its useful to also search a path on the root filesystem
@piggz
Copy link
Author

piggz commented Apr 7, 2022

The use case I have isnt related to normal firmwares being loaded.

On the Pro1, when a user performs a screen replacement, the screens come with an android tailored firmware which disables touches at the edges, which doesnt work well on sailfish. I have rebuilt the kernel to support flashing the TS firmware, and have the appropriate file, but the firmware loading fails on the other paths as theyre not mounted yet. By putting the firmware in /lib/firmware, its possible to update the TS firmware from sailfish, and users dont have t go back to android to do it.

@Thaodan
Copy link
Contributor

Thaodan commented Apr 7, 2022

Did you try without this? The kernel should pick /lib/firmware on its own.

@piggz
Copy link
Author

piggz commented Apr 7, 2022

I did, and it didnt. @mlehtima suggested a kernel config change, but this seems easier than ports having to rebuild dhd! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants