Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:color span added. #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jenisonleo
Copy link

The key for the span is "c" and the value is a list of four integers corresponding to ARGB.

@jenisonleo
Copy link
Author

@pulyaevskiy I am trying to make this editor support all the other smaller spans . Check for it's correctness and merge this if possible. A chat on gitter will also do.

@pulyaevskiy
Copy link
Contributor

Thanks for the PR!

Just wanted to note that I’m currently traveling and it’ll take some time for me to review this changes. I should be able to get back on this later next week.

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2b32049). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #27   +/-   ##
======================================
  Coverage          ?   90%           
======================================
  Files             ?     3           
  Lines             ?    40           
  Branches          ?     0           
======================================
  Hits              ?    36           
  Misses            ?     4           
  Partials          ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b32049...845e37a. Read the comment docs.

@pulyaevskiy
Copy link
Contributor

Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes?

3 similar comments
@pulyaevskiy
Copy link
Contributor

Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes?

@pulyaevskiy
Copy link
Contributor

Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes?

@pulyaevskiy
Copy link
Contributor

Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes?

@jenisonleo
Copy link
Author

jenisonleo commented Nov 9, 2018

Hi, @pulyaevskiy Sorry that,I wont be able to take this up until next month. Stuck up with some work. And by the what is else is left in this PR except UI for color span and unit tests?
Sorry, I am new to pull requests. So kindly explain in detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants