Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown decoder #191

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

nalbion
Copy link

@nalbion nalbion commented Oct 24, 2019

I have implemented the _NotusMarkdownDecoder but can not figure out how to nest blocks within block quotes - it is possible in Markdown, but does Notus have that capability? If so, how?

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #191 into master will increase coverage by 0.4%.
The diff coverage is 96.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #191     +/-   ##
=========================================
+ Coverage   90.63%   91.04%   +0.4%     
=========================================
  Files          12       12             
  Lines        1089     1172     +83     
=========================================
+ Hits          987     1067     +80     
- Misses        102      105      +3
Impacted Files Coverage Δ
packages/notus/lib/src/convert/markdown.dart 96.5% <96.47%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f102b9...06c4ebc. Read the comment docs.

@winwisely99
Copy link

@pulyaevskiy Any chance this can start to get reviewed

We are using zefyr heavily for our project and want to help get the Markdown encode and decode cycle working and so hoping a base approach like this can get mainlined so that we are others can contribute

@winwisely99
Copy link

@pulyaevskiy Also there are forked now way ahead of Master.

https://github.com/memspace/zefyr/network

Such as:
https://github.com/Yom3n/zefyr

sort of worried this is going to splinter.

@hallidev
Copy link

I'll just throw in my hat and say that I'd much appreciate this PR getting merged as well

@CanRau
Copy link
Contributor

CanRau commented Feb 24, 2020

Would be amazing to have md support 🎉 👏

@CanRau
Copy link
Contributor

CanRau commented Feb 24, 2020

@nalbion does it already handle images? can't get them to work using your fork locally

@rachitgambhir
Copy link

rachitgambhir commented Apr 2, 2020

Please review this change !! .. It will be great to have MD support on this editor

@SimonIT
Copy link

SimonIT commented Apr 5, 2020

I would love to see this PR merged.

I tried to use this with this md:

*   [ ] User Management
*   [ ] ApiClients
*   [ ] Settings

but I get this error: Style cannot be applied to this leaf node: {block: ul} 'package:notus/src/document/leaf.dart': Failed assertion: line 106 pos 12: 'value != null && (value.isInline || value.isEmpty)'

@andrewpmoore
Copy link

If I added your changes to a forked version of notus, how would I go about getting the zefyr to detect when you input the markdown text?

@arpitjacob
Copy link

When can we expect this? its stopping me from implementing zefyr in my app.

@ambrose-gladwell-sonocent

I have implemented the _NotusMarkdownDecoder but can not figure out how to nest blocks within block quotes - it is possible in Markdown, but does Notus have that capability? If so, how?

Hi @nalbion you can only nest headers and inline styles inside blockquotes rather than blocks in Zefyr at the moment.

@vishnukumarra
Copy link

When can we expect this? its stopping me from implementing zefyr in my app.

Same situation here .

@stuartwk
Copy link

Same situation, will this get merged in?

@nalbion
Copy link
Author

nalbion commented May 28, 2020

@ambrose-gladwell-sonocent there's a PR in Delta to support nested formatting - slab/delta#48

@TimWhiting
Copy link

Also interested

@boinxi
Copy link

boinxi commented Jul 2, 2020

interested as well.

@arpitjacob
Copy link

Don't think project is active anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.