Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ble): fix race condition for MAC addr device ID in sample #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 5, 2024

  1. fix(ble): set device ID after BLE init when using MAC address

      ### Summary
      The device ID when using the MAC address was Unknown after the system
      booted because the device has not been given a MAC address yet at the
      time the device ID is set (system init). This change removes the option
      for using a MAC address as the device id for BLE devices, and sets a
      static device id for the BLE sample app.
    
      ### Test Plan
      - Tested on a nRF52840 DK with the peripheral_mds sample app
      ```
    uart:~$ *** Booting nRF Connect SDK v3.5.99-ncs1-4965-g3733e7097909 ***
    Starting Bluetooth Memfault example
    Bluetooth initialized
    Advertising successfully started
    uart:~$ mflt get_device_info
    [00:00:03.995,544] <inf> mflt: S/N: nrf-ble-testdevice
    [00:00:03.995,605] <inf> mflt: SW type: nrf-ble-fw
    [00:00:03.995,666] <inf> mflt: SW version: 0.0.1+688c47
    [00:00:03.995,727] <inf> mflt: HW version: nrf52840dk_nrf52840
      ```
    gminn committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    80ce6da View commit details
    Browse the repository at this point in the history