Skip to content

memfault: add location session metrics #20

memfault: add location session metrics

memfault: add location session metrics #20

Triggered via pull request June 27, 2024 15:43
Status Failure
Total duration 2m 6s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
1m 56s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 5 warnings
Run compliance checks on patch series (PR): Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details db1068e5a48521eea22fc00b65f707b3ac96d468: author email (Gillian Minnehan <[email protected]>) needs to match one of the signed-off-by entries.
Run compliance checks on patch series (PR): Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing
Run compliance checks on patch series (PR): Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. TRAILING_WHITESPACE: trailing whitespace File:modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def Line:44 TRAILING_WHITESPACE: trailing whitespace File:modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def Line:49 C99_COMMENTS: do not use C99 // comments File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:114 LINE_SPACING: Missing a blank line after declarations File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:116 LINE_SPACING: Missing a blank line after declarations File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:119 C99_COMMENTS: do not use C99 // comments File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:164 C99_COMMENTS: do not use C99 // comments File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:166 C99_COMMENTS: do not use C99 // comments File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:168 SPACING: spaces required around that ':' (ctx:VxE) File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:169 LINE_SPACING: Missing a blank line after declarations File:modules/memfault-firmware-sdk/memfault_location_metrics.c Line:202
Run compliance checks on patch series (PR): GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes db1068e5a48521eea22fc00b65f707b3ac96d468: modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def:44: trailing whitespace. db1068e5a48521eea22fc00b65f707b3ac96d468: modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def:49: trailing whitespace.
Run compliance checks on patch series (PR)
Process completed with exit code 1.
TRAILING_WHITESPACE: modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def#L44
modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def:44 trailing whitespace
TRAILING_WHITESPACE: modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def#L49
modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def:49 trailing whitespace
C99_COMMENTS: modules/memfault-firmware-sdk/memfault_location_metrics.c#L114
modules/memfault-firmware-sdk/memfault_location_metrics.c:114 do not use C99 // comments
C99_COMMENTS: modules/memfault-firmware-sdk/memfault_location_metrics.c#L164
modules/memfault-firmware-sdk/memfault_location_metrics.c:164 do not use C99 // comments
C99_COMMENTS: modules/memfault-firmware-sdk/memfault_location_metrics.c#L166
modules/memfault-firmware-sdk/memfault_location_metrics.c:166 do not use C99 // comments
C99_COMMENTS: modules/memfault-firmware-sdk/memfault_location_metrics.c#L168
modules/memfault-firmware-sdk/memfault_location_metrics.c:168 do not use C99 // comments
SPACING: modules/memfault-firmware-sdk/memfault_location_metrics.c#L169
modules/memfault-firmware-sdk/memfault_location_metrics.c:169 spaces required around that ':' (ctx:VxE)
Run compliance checks on patch series (PR)
Process completed with exit code 4.
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "compliance.xml". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Run compliance checks on patch series (PR)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
LINE_SPACING: modules/memfault-firmware-sdk/memfault_location_metrics.c#L116
modules/memfault-firmware-sdk/memfault_location_metrics.c:116 Missing a blank line after declarations
LINE_SPACING: modules/memfault-firmware-sdk/memfault_location_metrics.c#L119
modules/memfault-firmware-sdk/memfault_location_metrics.c:119 Missing a blank line after declarations
LINE_SPACING: modules/memfault-firmware-sdk/memfault_location_metrics.c#L202
modules/memfault-firmware-sdk/memfault_location_metrics.c:202 Missing a blank line after declarations

Artifacts

Produced during runtime
Name Size
compliance.xml Expired
4.49 KB