Create server #1
Conversation
Noarkhh
force-pushed
the
create-server
branch
from
ddb2b13
to
fb35c6f
Compare
There was a problem hiding this comment.
- please update the readme
- add a usage example there - can be sending an mp4 via rtsp to Boombox
- you can also make it a test - run a server, send a file to Boombox, compare it with a fixture
BTW, I enabled Circle for this repo - it should run with the next commit
| end | ||
|
|
||
| defp build_tail(builder, type, config) do | ||
| config |> IO.inspect(label: type) |
lib/membrane/simple_rtsp_server.ex
Outdated
There was a problem hiding this comment.
cannot comment on line 7, but I'd use a keyword list instead of optional arguments
|
The test should pass once Boombox doesn't transcode when the input and output codecs are different |
test/integration_test.exs
Outdated
| Process.sleep(50) | ||
| Boombox.run(input: "rtsp://localhost:40001/", output: output_path) | ||
|
|
||
| assert File.read!(input_path) == File.read!(output_path) |
There was a problem hiding this comment.
For now, you can keep the output reference fixture and compare to it
There was a problem hiding this comment.
It seems that each time the output mp4 is generated it's slightly different
dupa.exs
Outdated
There was a problem hiding this comment.
whoops, a careless git add :P
| @@ -99,7 +95,11 @@ defmodule Membrane.SimpleRTSPServer.Pipeline do | |||
| clock_rate: config.clock_rate | |||
| ] | |||
| ) | |||
| |> child({:realtimer, type}, Membrane.Realtimer) | |||
| |> then( | |||
| &if realtime, | |||
There was a problem hiding this comment.
do you have a use case for realtime: false? I think it would overload the socket buffer and cause packet loss
There was a problem hiding this comment.
I wanted to have the test not take so long, but came to the same conclusion
There was a problem hiding this comment.
An alternative would be an option in realtimer that would speed it up a few times. And a relatively short fixture - I'm using up to 10s for such cases
Noarkhh
force-pushed
the
create-server
branch
from
75fdd38
to
00f68d5
Compare
Noarkhh
force-pushed
the
create-server
branch
from
ac0617e
to
79e7ea1
Compare
No description provided.