Smuxi emoticons #178
Smuxi emoticons #178
Conversation
|
Nice patch! But I tested it and it doesn't work. I mean, yeah, it shows the faces and stuff, but if I choose one and I hit enter, it doesn't send the smiley to the channel. And if I write some text after the smiley, and hit enter, it sends the buffer to the channel but the smiley is not included in what is sent to the channel... |
|
thank you very much i will resolve that problem |
|
here you are :-) |
|
Ok, it works now. But the images are not shown in the chat room, only when you select them. Is that expected? |
| @@ -357,6 +357,10 @@ public void AddMessage(MessageModel msg, bool addLinebreak, bool showTimestamps) | |||
| tags.Add(LinkTag); | |||
|
|
|||
| buffer.InsertWithTags(ref iter, linkText, tags.ToArray()); | |||
| } else if (msgPart is ImageMessagePartModel) { | |||
| var imgMsgPart = (ImageMessagePartModel) msgPart; | |||
| var imgPixbuf = Frontend.LoadIcon(imgMsgPart.ImageFileName, 16, imgMsgPart.ImageFileName + ".png"); | |||
There was a problem hiding this comment.
This assumption that any image is an emoticon can't be done. Either a special URI prefix needs to be used to at least the file name needs to be checked for the emoticon name pattern face-XXX-symbolic
|
The man who sold the world |
Is that an answer to my question? Because I don't understand it. |
|
sorry it was just a notification for meebey, you could test now, it works, thank you |
| @@ -0,0 +1,67 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
Move the .svg files to the same directory as the .png files (images/Smuxi-Emoticons/)
|
I am here , do you see me now :) |
| @@ -357,6 +358,10 @@ public void AddMessage(MessageModel msg, bool addLinebreak, bool showTimestamps) | |||
| tags.Add(LinkTag); | |||
|
|
|||
| buffer.InsertWithTags(ref iter, linkText, tags.ToArray()); | |||
| } else if (msgPart is ImageMessagePartModel) { | |||
| var imgMsgPart = (ImageMessagePartModel) msgPart; | |||
| var emoticonPixbuf = EmoticonStore.GetEmoticonImage(EmoticonStore[imgMsgPart.ImageFileName], 16); | |||
There was a problem hiding this comment.
Don't always load ALL images from the emoticon store, it could also be a regular file, URL or whatever! Something NOT smiley
|
add new symbolic emoticons, create one instance for EmoticonsWindow call (to do not watse many resources) |
|
Add new images with dimension 256x256 |
| // private void OnDestroyed(object obj, EventArgs args) | ||
| // { | ||
| // Active = false; | ||
| // }ram is distributed in the hope that it will be useful, |
|
Was this PR superseded by some work already merged in the master branch? |
Add emoticons to Smuxi, hope that they will make it more gorgeous 👍