Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu integration #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kybarg
Copy link

@kybarg kybarg commented Jan 3, 2016

No description provided.

@mebibou
Copy link
Owner

mebibou commented Jan 4, 2016

Could you provide an example on how this would be used? maybe you could add something in the README? thx

@kybarg
Copy link
Author

kybarg commented Jan 4, 2016

@mebibou Sure thing. Here http://codepen.io/kybarg/pen/dGNeYw

@mebibou
Copy link
Owner

mebibou commented Feb 27, 2016

@kybarg to come back on this (sorry I kind of forgot about it), this integration makes the select field not behave like a standard html5 element, which is not the idea behind this library.

But it could be an option that could be enabled by setting a class on the element, like mdl-selectfield--menu, and this should be in the documentation (README.md)

@mebibou
Copy link
Owner

mebibou commented Feb 27, 2016

Also, please make sure you code is jscs compliant, i.e. run jscs src/selectfield/selectfield.js and fix errors before commit, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants