-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Recipe From HTML or JSON #4274
Open
michael-genson
wants to merge
16
commits into
mealie-recipes:mealie-next
Choose a base branch
from
michael-genson:feat/create-recipe-from-json
base: mealie-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Create Recipe From HTML or JSON #4274
michael-genson
wants to merge
16
commits into
mealie-recipes:mealie-next
from
michael-genson:feat/create-recipe-from-json
+407
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
force-pushed
the
feat/create-recipe-from-json
branch
from
September 26, 2024 21:04
c55654f
to
53bf00d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR adds the ability to create a recipe from raw HTML or JSON. We leverage the existing URL scrapers as-is, but bypass calling the target URL and instead provide the HTML/JSON directly (JSON must be in schema.org format, although if OpenAI is enabled it might figure it out regardless).
This is suggested on the create by URL page:
Which brings you here:
You can put HTML or JSON into that text field, however you may optionally use the JSON editor mode for JSON:
The main advantages of this are:
Which issue(s) this PR fixes:
(REQUIRED)
Closes #3224
Closes #2391
Special notes for your reviewer:
I changed some of the "create" route names because they're getting a bit unorganized. All recipe create routes are now under
/recipe/create/...
. This is a breaking change, so I added it to the migration docs.Testing
(fill-in or delete this section)
Pytest