Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown Category instead of returning an error #29

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

shamilsan
Copy link
Contributor

I encountered a problem when trying to open one MSI package with undocumented “Number” category. In my opinion, it is better to ignore unknown categories rather than to return an error.

@shamilsan
Copy link
Contributor Author

Dear @mdsteele,

What do you think about it?

@mdsteele
Copy link
Owner

mdsteele commented Aug 1, 2024

Seems reasonable, sorry for the slow reply. Looks like there were some clippy errors unrelated to your change; if you rebase those should be fixed now, and then we can merge.

@shamilsan
Copy link
Contributor Author

@mdsteele,

Thanks for your reply. I've synced my fork with the upstream, could you please try again?

@mdsteele mdsteele merged commit aa64fb3 into mdsteele:master Aug 1, 2024
4 checks passed
@mdsteele
Copy link
Owner

mdsteele commented Aug 1, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants