Skip to content
This repository has been archived by the owner on Nov 19, 2023. It is now read-only.

RadGH, Part 2 — Wp4.5 #1

Merged
merged 30 commits into from
Dec 6, 2016
Merged

RadGH, Part 2 — Wp4.5 #1

merged 30 commits into from
Dec 6, 2016

Conversation

mcaskill
Copy link
Owner

@mcaskill mcaskill commented Dec 6, 2016

From tomaszsita#54

Here's a new collection of changes made to your plugin. This expands on a previous pull request I submitted earlier: tomaszsita#49

New changes since that pull request are:

  1. Converted quality dropdowns to numeric inputs, allowing sizes like 85% (This behavior may not be desired, if so then skip commit 07ce8aa)
  2. If you use Regenerate Thumbnails, a new option will re-crop an image after the thumbnails have been regenerated.
  3. Due to the above, I removed the warning that Regenerate Thumbnails was incompatible has been removed. This warning was added in the previous pull request.
  4. Fixed a few URLs which were not giving a full admin url. Probably not necessary unless you have a custom admin url set up.
  5. Fixed a few small code errors so my IDE (phpstorm) was happier.
    Note: Some users on wordpress.org complained about problems with the dialog closing and not saving images. I have not experienced this issue with my build of the plugin. If you can replicate the problem in your own version, you might find this version works. I'm not sure if that's the case, I haven't tested the original in some time ;)

Radley Sustaire added 30 commits December 1, 2015 15:06
…ail on cropping images for future plugin support.
@mcaskill mcaskill changed the title Wp4.5 RadGH, Part 2 — Wp4.5 Dec 6, 2016
@mcaskill mcaskill merged commit 662a276 into mcaskill:master Dec 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant