Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@nf-team/react): useEffectOnce hook 구현 #49

Merged
merged 2 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-pumas-invite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nf-team/react": minor
---

feat(@nf-team/react): useEffectOnce hook 구현
1 change: 1 addition & 0 deletions packages/react/src/hooks/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export { default as useActionKeyEvent } from './useActionKeyEvent';
export { default as useBoolean } from './useBoolean';
export { default as useDebounce } from './useDebounce';
export { default as useEffectOnce } from './useEffectOnce';
export { default as useIsFirstRender } from './useIsFirstRender';
export { default as useIsMounted } from './useIsMounted';
export { default as useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect';
Expand Down
29 changes: 29 additions & 0 deletions packages/react/src/hooks/useEffectOnce.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { act, renderHook } from '@testing-library/react';

import useEffectOnce from './useEffectOnce';

describe('useEffectOnce', () => {
const effectCallback = jest.fn();

beforeEach(() => {
jest.clearAllMocks();
});

const useEffectOnceHook = () => renderHook(() => useEffectOnce(effectCallback));

it('effect callback 함수가 1번 호출되어야만 한다', () => {
useEffectOnceHook();

expect(effectCallback).toHaveBeenCalledTimes(1);
});

it('rendering이 여러번 발생해도 effect callback 함수가 1번 호출되어야만 한다', () => {
const { rerender } = useEffectOnceHook();

act(() => {
rerender();
});

expect(effectCallback).toHaveBeenCalledTimes(1);
});
});
7 changes: 7 additions & 0 deletions packages/react/src/hooks/useEffectOnce.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { EffectCallback, useEffect } from 'react';

function useEffectOnce(effect: EffectCallback) {
useEffect(effect, []);

Check warning on line 4 in packages/react/src/hooks/useEffectOnce.ts

View workflow job for this annotation

GitHub Actions / check unit test & lint

React Hook useEffect has a missing dependency: 'effect'. Either include it or remove the dependency array
}

export default useEffectOnce;
Loading