subtraction function #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridget127
requested review from
jasperdoan,
max9001 and
snappyappleTheSimple
jasperdoan
reviewed
Oct 12, 2022
| @@ -14,6 +15,9 @@ int main() | |||
| //now call add number x times function | |||
| addNumberXTimes(3, 10); | |||
|
|
|||
| //now call subtract numbers function | |||
| subtractNumbers(9,7); | |||
|
|
|||
jasperdoan
reviewed
Oct 12, 2022
| void subtractNumbers(int num1, int num2) | ||
| { | ||
| cout << num1 << " - " << num2 << " = " << num1-num2 << endl; | ||
| } |
There was a problem hiding this comment.
Great work, though I'd pollute your function with documentation just because 😎
jasperdoan
requested changes
Oct 12, 2022
| "path": "." | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
This is generated by VSCode and should only be local to your machine. I'd suggest adding this file into .gitignore. So for your next commit, it will ignore this file upon committing.
There was a problem hiding this comment.
I agree. Fix this then we can merge
snappyappleTheSimple
approved these changes
Oct 12, 2022
max9001
requested changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a subtract numbers function