Ensure header background on profile screen is not rendered in Loading…

… and Error states
mattmook · Jan 26, 2021 · 5398805 · 5398805
1 parent de6adcc
commit 5398805
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/androidApp/src/main/kotlin/com/mattdolan/cv/profile/ProfileFragment.kt b/androidApp/src/main/kotlin/com/mattdolan/cv/profile/ProfileFragment.kt
@@ -92,7 +92,7 @@ class ProfileFragment : Fragment() {
 
         ShadowScrollBehavior(requireContext()).onDependentViewChanged(
             scrollingView = binding.recyclerView,
-            binding.background, binding.image, binding.name, binding.tagline, binding.location, binding.chipGroup
+            binding.background, binding.image, binding.name, binding.tagline, binding.location, binding.chipGroup, binding.pad
         )
 
         lifecycleScope.launch {
@@ -113,22 +113,19 @@ class ProfileFragment : Fragment() {
     private fun render(state: ProfileState) {
         when (state) {
             ProfileState.Loading -> {
-                if (binding.mainView.currentState == R.id.error) {
-                    println("trigger state change loading")
+                if (binding.mainView.currentState != R.id.loading) {
                     binding.mainView.setTransition(R.id.loadingToError)
                     binding.mainView.transitionToStart()
                 }
             }
             ProfileState.Error -> {
-                if (binding.mainView.currentState == R.id.loading) {
-                    println("trigger state change error")
+                if (binding.mainView.currentState != R.id.error) {
                     binding.mainView.setTransition(R.id.loadingToError)
                     binding.mainView.transitionToEnd()
                 }
             }
             is ProfileState.Ready -> {
                 if (binding.mainView.currentState == R.id.loading) {
-                    println("trigger state change ready")
                     binding.mainView.setTransition(R.id.loadingToReady)
                     binding.mainView.transitionToEnd()
                 }

diff --git a/androidApp/src/main/res/xml/profile_fragment_scene.xml b/androidApp/src/main/res/xml/profile_fragment_scene.xml
@@ -19,6 +19,9 @@
         </Constraint>
 
         <!-- content -->
+        <Constraint android:id="@+id/background">
+            <PropertySet android:visibility="invisible" />
+        </Constraint>
         <Constraint android:id="@+id/image">
             <PropertySet android:visibility="invisible" />
         </Constraint>
@@ -69,6 +72,9 @@
         </Constraint>
 
         <!-- content -->
+        <Constraint android:id="@+id/background">
+            <PropertySet android:visibility="visible" />
+        </Constraint>
         <Constraint android:id="@+id/image">
             <PropertySet android:visibility="visible" />
         </Constraint>