-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the saml-idp.crt file in assets #792
Conversation
Without this line, the deployment fails because it cannot do t.getAsset
I also see another asset |
|
Okay, if it's not needed always, then it's fine. But we do need the |
I just checked and I had it in my state dir. what are the ways a file can end up there? I started from scratch two weeks ago. |
Hmm no idea 🤷♂️ But anyways, do test with a fresh setup and see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a cluster creation from scratch, 👌
@agnivade, can you fix the conflicts to get this merged for the new v1.21 release? |
Without this line, the deployment fails because it cannot do t.getAsset
Without this line, the deployment fails because
it cannot do t.getAsset