Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the saml-idp.crt file in assets #792

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Restore the saml-idp.crt file in assets #792

merged 2 commits into from
Sep 13, 2024

Conversation

agnivade
Copy link
Member

Without this line, the deployment fails because
it cannot do t.getAsset

Without this line, the deployment fails because
it cannot do t.getAsset
@agnivade agnivade added the 2: Dev Review Requires review by a core committer label Aug 30, 2024
@agnivade
Copy link
Member Author

I also see another asset keycloak-users.txt, which is not restored. Will leave it to @fmartingr

@fmartingr
Copy link
Contributor

keycloak-users.txt is a file created by the process if the GenerateUsersCount is higher than zero, unsure if this applies. I haven't used this for any asset IIRC, what is this used for? And how it could be that it didn't fail for me before?

@agnivade
Copy link
Member Author

agnivade commented Sep 2, 2024

Okay, if it's not needed always, then it's fine. But we do need the saml-idp.crt. Maybe you can test with a fresh setup? Perhaps you had the saml-idp.crt file somehow already in your terraform state dir?

@fmartingr
Copy link
Contributor

Okay, if it's not needed always, then it's fine. But we do need the saml-idp.crt. Maybe you can test with a fresh setup? Perhaps you had the saml-idp.crt file somehow already in your terraform state dir?

I just checked and I had it in my state dir. what are the ways a file can end up there? I started from scratch two weeks ago.

@agnivade
Copy link
Member Author

agnivade commented Sep 2, 2024

Hmm no idea 🤷‍♂️ But anyways, do test with a fresh setup and see.

Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a cluster creation from scratch, 👌

@agnivade agnivade added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 11, 2024
@agarciamontoro
Copy link
Member

@agnivade, can you fix the conflicts to get this merged for the new v1.21 release?

@agnivade agnivade merged commit 7f6be66 into master Sep 13, 2024
1 check passed
@agnivade agnivade deleted the samlidp branch September 13, 2024 04:31
fmartingr pushed a commit that referenced this pull request Sep 17, 2024
Without this line, the deployment fails because
it cannot do t.getAsset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants