Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client metrics #751

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
36460a1
WIP: add client metrics
isacikgoz May 28, 2024
ca3db46
Merge remote-tracking branch 'origin/master' into add-client-metrics
isacikgoz May 28, 2024
d1ca053
remove toolchain
isacikgoz May 28, 2024
efce9ac
reflect revivew comments
isacikgoz Jun 3, 2024
b462c21
fix golangci
isacikgoz Jun 3, 2024
7e067aa
Merge remote-tracking branch 'origin/master' into add-client-metrics
isacikgoz Jun 11, 2024
6656416
remove golint
isacikgoz Jun 11, 2024
e8be503
address review comments
isacikgoz Jun 11, 2024
a7ff258
Apply suggestions from code review
isacikgoz Jul 30, 2024
1c9dbce
[MM-58179] Review networking performance at scale (#752)
streamer45 Jun 12, 2024
6b15c15
Update postgres client (#755)
streamer45 Jun 13, 2024
b1a23cd
Bump version strings in master (#757)
agarciamontoro Jun 19, 2024
eba5843
Update retransmission threshold (#760)
agnivade Jul 2, 2024
6da2986
Update coverage frequency docs (#761)
agarciamontoro Jul 3, 2024
1692691
MM-59319: Allow opensearch installations to be created (#763)
agnivade Jul 4, 2024
67dfe4d
Allow 0 shard replicas (#764)
agarciamontoro Jul 5, 2024
d205832
MM-59316: Remove cloudwatch log policy (#762)
agarciamontoro Jul 15, 2024
94df8c1
Improvements from Redis investigation (#765)
agnivade Jul 15, 2024
5e0bf36
feat: allow saml with the external auth provider (#759)
fmartingr Jul 22, 2024
7b334a4
Revert the disabling of proxy_cache_lock (#768)
agarciamontoro Jul 25, 2024
0ee03f2
Bump v1.19.0 rc2 (#770)
agarciamontoro Jul 25, 2024
738672d
Run make update-dependencies (#772)
agarciamontoro Jul 26, 2024
7638e57
Fix race condition in RoundTrip test (#774)
agarciamontoro Jul 29, 2024
2aa80fc
Bump version to v1.19.0 (#775)
agarciamontoro Jul 29, 2024
382152f
Add local file option for Mattermost download url (#767)
cpoile Jul 29, 2024
53b1c87
Fix incorrect deployer.sample.json (#776)
agnivade Jul 30, 2024
ca56401
Update the load test dashboard panels to new format (#777)
agnivade Jul 30, 2024
f91dc82
reflect reviews
isacikgoz Jul 30, 2024
a42059f
fix the TTFB measurement
isacikgoz Jul 30, 2024
016e7ac
Merge remote-tracking branch 'origin/master' into add-client-metrics
isacikgoz Jul 30, 2024
2562236
remove ttb observation from controller actions
isacikgoz Jul 31, 2024
02a451d
Merge remote-tracking branch 'origin/master' into add-client-metrics
isacikgoz Aug 12, 2024
abda30f
Merge remote-tracking branch 'origin/master' into add-client-metrics
isacikgoz Sep 9, 2024
63fd563
revert TTFB measurement to be calculated only on login
isacikgoz Sep 9, 2024
06bc18a
remove random platform/agent
isacikgoz Sep 9, 2024
7d1e7a8
Merge remote-tracking branch 'origin/master' into add-client-metrics
isacikgoz Sep 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ linters-settings:
gofmt:
simplify: true
govet:
check-shadowing: false # set this to true from time to time to check for possible issues
disable-all: true
enable:
- asmdecl # report mismatches between assembly files and Go declarations
Expand Down Expand Up @@ -36,7 +35,7 @@ linters:
disable-all: true
enable:
- gofmt # Checks whether code was gofmt-ed
- golint # Differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes
# - revive # Differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes
isacikgoz marked this conversation as resolved.
Show resolved Hide resolved
- gosimple # Linter for Go source code that specializes in simplifying a code
- govet # Examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
- ineffassign # Detects when assignments to existing variables are not used
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ verify-gomod: ## Run go mod verify.
check-style: golangci-lint ## Check the style of the code.

golangci-lint:
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57

@echo Running golangci-lint
$(GOBIN)/golangci-lint run ./...
Expand Down
1 change: 0 additions & 1 deletion deployment/terraform/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,6 @@ func (t *Terraform) updateAppConfig(siteURL string, sshc *ssh.Client, jobServerE
cfg.TeamSettings.MaxNotificationsPerChannel = model.NewInt64(1000)

cfg.ClusterSettings.GossipPort = model.NewInt(8074)
cfg.ClusterSettings.StreamingPort = model.NewInt(8075)
cfg.ClusterSettings.Enable = model.NewBool(true)
cfg.ClusterSettings.ClusterName = model.NewString(t.config.ClusterName)
cfg.ClusterSettings.ReadOnlyConfig = model.NewBool(false)
Expand Down
6 changes: 3 additions & 3 deletions deployment/terraform/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ func validateLicense(filename string) error {
}

validator := &utils.LicenseValidatorImpl{}
ok, licenseStr := validator.ValidateLicense(data)
if !ok {
return errors.New("failed to validate license")
licenseStr, err := validator.ValidateLicense(data)
if err != nil {
return fmt.Errorf("failed to validate license: %w", err)
}

var license model.License
Expand Down
23 changes: 12 additions & 11 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/mattermost/mattermost-load-test-ng

go 1.20
go 1.21
isacikgoz marked this conversation as resolved.
Show resolved Hide resolved

require (
github.com/blang/semver v3.5.1+incompatible
Expand All @@ -26,8 +26,8 @@ require (
github.com/elastic/go-elasticsearch/v7 v7.10.1-0.20201228193145-776f23a0c901
github.com/gliderlabs/ssh v0.1.1
github.com/graph-gophers/graphql-go v1.5.1-0.20230110080634-edea822f558a
github.com/mattermost/mattermost/server/public v0.0.15-0.20240228165319-9e99280a40f1
github.com/mattermost/mattermost/server/v8 v8.0.0-20240228165319-9e99280a40f1
github.com/mattermost/mattermost/server/public v0.1.4-0.20240527204624-beb8d5e8e07a
github.com/mattermost/mattermost/server/v8 v8.0.0-20240527204624-beb8d5e8e07a
github.com/pelletier/go-toml/v2 v2.2.2
github.com/vmihailenco/msgpack/v5 v5.4.1
github.com/wiggin77/merror v1.0.5
Expand Down Expand Up @@ -65,33 +65,34 @@ require (
github.com/francoispqt/gojay v1.2.13 // indirect
github.com/go-sql-driver/mysql v1.7.1 // indirect
github.com/gobwas/glob v0.2.3 // indirect
github.com/golang-migrate/migrate/v4 v4.17.0 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.3 // indirect
github.com/google/go-querystring v1.1.0 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/hashicorp/go-hclog v1.6.2 // indirect
github.com/hashicorp/go-multierror v1.1.1 // indirect
github.com/hashicorp/go-plugin v1.6.0 // indirect
github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect
github.com/hashicorp/yamux v0.1.1 // indirect
github.com/imkira/go-interpol v1.1.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/jmoiron/sqlx v1.3.5 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/kennygrant/sanitize v1.2.4 // indirect
github.com/klauspost/compress v1.17.7 // indirect
github.com/klauspost/cpuid/v2 v2.2.7 // indirect
github.com/lann/builder v0.0.0-20180802200727-47ae307949d0 // indirect
github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 // indirect
github.com/lib/pq v1.10.9 // indirect
github.com/mattermost/go-i18n v1.11.1-0.20211013152124-5c415071e404 // indirect
github.com/mattermost/logr/v2 v2.0.21 // indirect
github.com/mattermost/morph v1.1.0 // indirect
github.com/mattermost/squirrel v0.4.0 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/minio/minio-go/v7 v7.0.67 // indirect
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/moul/http2curl v1.0.0 // indirect
github.com/ncruces/go-strftime v0.1.9 // indirect
github.com/oklog/run v1.1.0 // indirect
github.com/onsi/ginkgo v1.16.5 // indirect
github.com/onsi/gomega v1.18.1 // indirect
github.com/pborman/uuid v1.2.1 // indirect
Expand All @@ -105,7 +106,6 @@ require (
github.com/saintfish/chardet v0.0.0-20230101081208-5e3ef4b5456d // indirect
github.com/smartystreets/goconvey v1.8.1 // indirect
github.com/spf13/pflag v1.0.5 // indirect
github.com/stretchr/objx v0.5.2 // indirect
github.com/temoto/robotstxt v1.1.2 // indirect
github.com/tinylib/msgp v1.1.9 // indirect
github.com/valyala/bytebufferpool v1.0.0 // indirect
Expand All @@ -120,10 +120,11 @@ require (
github.com/yudai/pp v2.0.1+incompatible // indirect
github.com/yuin/goldmark v1.7.0 // indirect
golang.org/x/net v0.21.0 // indirect
golang.org/x/sync v0.6.0 // indirect
golang.org/x/sys v0.17.0 // indirect
golang.org/x/text v0.14.0 // indirect
google.golang.org/appengine v1.6.8 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240227224415-6ceb2ff114de // indirect
google.golang.org/grpc v1.62.0 // indirect
google.golang.org/protobuf v1.32.0 // indirect
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
Expand Down
Loading
Loading