Multi Tenant suggestion #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi Tenant suggestion
|
@AltamashShaikh Do you know why this PR was never merged? Did we simply not notice that it had been created? Do you see a reason not to merge this or should we wait till after Matomo 5.0.0? |
|
@snake14 Dunno why this was never merged, I think we missed it and just adding braces with if is my suggestion to this PR |
|
@snake14 This would require migration too right ? |
Good call @AltamashShaikh . Since it would be looking for a different key, we would probably want a migration for existing installations. I'll mark this PR for needing to be moved to 5.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion Multi Tenant.
I'm working with a multi tenant setup as described here in the Matomo documentation. The documentation describes how split the mysql database.
Having multiple redis-server as backends can be complicated instead.
It could be possibile to use multiple databases in redis, but performance can become awful when period flush to disk is active.
Adding a suffix to the list key with the Matomo hostname picked from the $trusted_hosts config variable can be a solution, avoiding conflicts across instances.