Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance class completed #1464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Waldemar-wal
Copy link

No description provided.

app/main.py Outdated
def __add__(self, other: any) -> Distance:
if isinstance(other, Distance):
return Distance(self.km + other.km)
else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else is redundant

app/main.py Outdated
def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: any) -> Distance:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix type annotations, it should be - float | int | Distance

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in all places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants