Solution #1453
Open
Solution #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlhaStadnik
approved these changes
Oct 3, 2024
AnyoneClown
suggested changes
Oct 3, 2024
app/main.py
Outdated
Comment on lines
6
to
7
| def __init__(self, km: int) -> None: | ||
| self.km = km |
There was a problem hiding this comment.
km can also be float. Fix in all cases
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
Import annotation from future to use type hints without quotes
app/main.py
Outdated
Comment on lines
16
to
19
| if isinstance(other, Distance): | ||
| return Distance(self.km + other.km) | ||
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) |
There was a problem hiding this comment.
We don't need to check it twice. If it's not Distance - it will be int or float
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.