Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1451

wants to merge 1 commit into from

Conversation

Rabb1t-Artem
Copy link

No description provided.

AnyoneClown
AnyoneClown approved these changes Oct 3, 2024
View reviewed changes
Copy link

@AnyoneClown AnyoneClown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but fix type hints

app/main.py
def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: Distance) -> Distance:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other can be also float or int type here

app/main.py
class Distance:
# Write your code here
pass
def __init__(self, km: int) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

km can also be float here. Fix in all places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnyoneClown AnyoneClown AnyoneClown approved these changes

@YaroslavK87 YaroslavK87 YaroslavK87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rabb1t-Artem @AnyoneClown @YaroslavK87