Solution #1445
Open
Solution #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKvladys
approved these changes
Oct 2, 2024
app/main.py
Outdated
|
|
||
| def __truediv__(self, other: int | float) -> "Distance": | ||
| if isinstance(other, (int, float)): | ||
| return Distance(round(self.km / other, 2)) |
There was a problem hiding this comment.
in metods "mul" and "truediv" you dont need to check "other" for int/float types, because he not be of type Distance
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km < other |
There was a problem hiding this comment.
you can skip "elif" her and below and just use "return"
There was a problem hiding this comment.
👍 fix this in all cases
Also add annotation for Disntace in other argument
AnyoneClown
suggested changes
Oct 3, 2024
app/main.py
Outdated
Comment on lines
2
to
3
| def __init__(self, km: float) -> None: | ||
| self.km = km |
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: int | float) -> "Distance": |
app/main.py
Outdated
Comment on lines
12
to
15
| if isinstance(other, Distance): | ||
| return Distance(self.km + other.km) | ||
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) |
There was a problem hiding this comment.
We don't need to check for type twice. If it's not Distance -> it will be float or int type
app/main.py
Outdated
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) | ||
|
|
||
| def __iadd__(self, other: int | float) -> "Distance": |
There was a problem hiding this comment.
Import annotations from future to use classes as type hints without quotes
app/main.py
Outdated
|
|
||
| def __truediv__(self, other: int | float) -> "Distance": | ||
| if isinstance(other, (int, float)): | ||
| return Distance(round(self.km / other, 2)) |
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km < other |
There was a problem hiding this comment.
👍 fix this in all cases
Also add annotation for Disntace in other argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.