Fix incompatible function pointer types #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix
src/filebrowser.c:380:27: warning: incompatible function pointer types initializing '_mode_get_icon' (aka 'struct _cairo_surface *(*)(const struct rofi_mode *, unsigned int, unsigned int)') with an expression of type 'cairo_surface_t *(const Mode *, unsigned int, int)' (aka 'struct _cairo_surface *(const struct rofi_mode *, unsigned int, int)') [-Wincompatible-function-pointer-types]
._get_icon = file_browser_get_icon,
^~~~~~~~~~~~~~~~~~~~~
See also https://bugs.gentoo.org/880985
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 11, 2022
…r-types Closes: https://bugs.gentoo.org/880985 Signed-off-by: Florian Schmaus <[email protected]> Upstream: marvinkreis/rofi-file-browser-extended#49
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 13, 2024
The build fails with the following error:
FAILED: CMakeFiles/filebrowser.dir/src/filebrowser.c.o
/usr/bin/cc -D_XOPEN_SOURCE=700 -Dfilebrowser_EXPORTS -I/wrkdirs/usr/ports/x11/rofi-file-browser-extended/work/rofi-file-browser-extended-1.3.1/include -I/usr/local/include/cairo -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/libpng16 -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -DNDEBUG -fPIC -MD -MT CMakeFiles/filebrowser.dir/src/filebrowser.c.o -MF CMakeFiles/filebrowser.dir/src/filebrowser.c.o.d -o CMakeFiles/filebrowser.dir/src/filebrowser.c.o -c /wrkdirs/usr/ports/x11/rofi-file-browser-extended/work/rofi-file-browser-extended-1.3.1/src/filebrowser.c
/wrkdirs/usr/ports/x11/rofi-file-browser-extended/work/rofi-file-browser-extended-1.3.1/src/filebrowser.c:380:27: error: incompatible function pointer types initializing '_mode_get_icon' (aka 'struct _cairo_surface *(*)(const struct rofi_mode *, unsigned int, unsigned int)') with an expression of type 'cairo_surface_t *(const Mode *, unsigned int, int)' (aka 'struct _cairo_surface *(const struct rofi_mode *, unsigned int, int)') [-Wincompatible-function-pointer-types]
._get_icon = file_browser_get_icon,
^~~~~~~~~~~~~~~~~~~~~
1 error generated.
So apply the patch provided at
marvinkreis/rofi-file-browser-extended#49
and used by the Gentoo port too:
https://bugs.gentoo.org/880985
Reported by: pkg-fallout
|
friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.