Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Censor password in debug output #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graulund
Copy link

(Re-added from botched pull request #497)

When you're developing something that uses this IRC library, with other people watching, and using the library's debug mode, it would be nice if it does not print your IRC password in plain text into the console.

So I made a change that detects any PASS commands being output, and censors the output in a fairly simple manner.

I realise there can be more than one opinion about this, so obviously feel free to not merge it, but it's just a problem that I personally experienced. Thanks for a great library! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant