fix: Error on too few snapshots and too short #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window size
apollo-sturdy
force-pushed
the
dev/twap-params-validation
branch
from
d866079
to
364a08e
Compare
pacmanifold
reviewed
Jun 29, 2023
| @@ -174,6 +174,12 @@ impl PriceSourceUnchecked<WasmPriceSourceChecked, Empty> for WasmPriceSourceUnch | |||
| &route_assets, | |||
| )?; | |||
|
|
|||
| if window_size <= 1 { | |||
There was a problem hiding this comment.
set this either as const MIN_WINDOW_SIZE or config item?
There was a problem hiding this comment.
Could set it as a const if you prefer, but it shouldn't be changeable. Its just that the logic breaks (subtraction underflow) if you set it to 1 or less.
| @@ -307,6 +313,10 @@ fn query_astroport_twap_price( | |||
| .may_load(deps.storage, denom)? | |||
| .ok_or(ContractError::NoSnapshots {})?; | |||
|
|
|||
| if snapshots.len() < 2 { | |||
There was a problem hiding this comment.
set as either const MIN_NUM_OF_SNAPSHOTS or config item?
dancreee
approved these changes
Jun 29, 2023
grod220
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window size