Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle current content + allow to keep model clean #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

levraipixel
Copy link

Hi,

I fixed a tiny bug that needed a timeout so that angular is executed before jQuery, and I added a way to keep a model with a clean value of the number.
I didn't know if changing the "repository" URL as mandatory for my local bower to work, please remove this particular change if you merge in order not to break your cool work :)

Yann

@@ -20,6 +20,6 @@
"author": "Marek Pietrucha (http://enginearch.com)",
"repository": {
"type": "git",
"url": "https://github.com/mareczek/international-phone-number.git"
"url": "https://github.com/yhourdel/international-phone-number.git"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing the URL?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I'm using this version in my project and I believe bower needs the URL to pull the repo. Of course you will need to put your repo's URL back into place afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants