-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for AVAX retro funding payload, fix amounts #14
Conversation
Made changes to all amounts to reflect the approved amounts in the AIP (https://app.aave.com/governance/proposal/?proposalId=98) versus using the rounded amounts in the ARC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please review your imports
- pls do pre execution/ post snapshots of collector balances and generate diff report on top of assert tests
- pls merge commits ahead of yours.
src/AaveV3AvaxretrofundingPayload_20230626/AaveV3AvaxretrofundingPayload_20230626_Test.t.sol
Show resolved
Hide resolved
src/AaveV3AvaxretrofundingPayload_20230626/AaveV3AvaxretrofundingPayload_20230626_Test.t.sol
Show resolved
Hide resolved
Thanks for the feedback! Let us know if there is anything else you want us to amend or review. |
I can still see wrong import and test still fails are we still waiting for a commit? |
Yes, I was awaiting confirmation re: the snapshot question prior to pushing the remaining local change - I opened a new PR with the test executor change (#15 ) |
Hi! I'm sending along a PR that adds a test for the AaveV3AvaxretrofundingPayload. As part of this, I reviewed the ARC and noticed that - in the original payload - the aAvaWBTC and avWBTC amounts were flipped around as well (hence the payload change). Happy to discuss anything here further!