Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for AVAX retro funding payload, fix amounts #14

Merged
merged 9 commits into from Jul 28, 2023
Merged

Add test for AVAX retro funding payload, fix amounts #14

merged 9 commits into from Jul 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2023

Hi! I'm sending along a PR that adds a test for the AaveV3AvaxretrofundingPayload. As part of this, I reviewed the ARC and noticed that - in the original payload - the aAvaWBTC and avWBTC amounts were flipped around as well (hence the payload change). Happy to discuss anything here further!

@ghost
Copy link
Author

ghost commented Jul 19, 2023

Made changes to all amounts to reflect the approved amounts in the AIP (https://app.aave.com/governance/proposal/?proposalId=98) versus using the rounded amounts in the ARC.

Copy link
Owner

@marczeller marczeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please review your imports
  2. pls do pre execution/ post snapshots of collector balances and generate diff report on top of assert tests
  3. pls merge commits ahead of yours.

@ghost ghost marked this pull request as draft July 28, 2023 13:18
@ghost ghost changed the base branch from feat/V3RetroFundingAVAX to main July 28, 2023 13:40
@ghost ghost changed the base branch from main to feat/V3RetroFundingAVAX July 28, 2023 13:42
@ghost ghost changed the base branch from feat/V3RetroFundingAVAX to main July 28, 2023 13:44
@miguelmtzinf
Copy link

  1. please review your imports
  2. pls do pre execution/ post snapshots of collector balances and generate diff report on top of assert tests
  3. pls merge commits ahead of yours.

Thanks for the feedback! Let us know if there is anything else you want us to amend or review.

@marczeller marczeller marked this pull request as ready for review July 28, 2023 16:42
@marczeller marczeller merged commit eb50810 into marczeller:main Jul 28, 2023
1 of 2 checks passed
@marczeller
Copy link
Owner

I can still see wrong import and test still fails are we still waiting for a commit?

@ghost
Copy link
Author

ghost commented Jul 28, 2023

I can still see wrong import and test still fails are we still waiting for a commit?

Yes, I was awaiting confirmation re: the snapshot question prior to pushing the remaining local change - I opened a new PR with the test executor change (#15 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants