Skip to content

Commit

Permalink
Bug 1917957 [wpt PR 48086] - webnn: Add MLOperandDescriptor.shape and…
Browse files Browse the repository at this point in the history
… discourage use of dimensions, a=testonly

Automatic update from web-platform-tests
webnn: Add MLOperandDescriptor.shape and discourage use of dimensions

Renaming MLOperandDescriptor.dimensions to MLOperandDescriptor.shape
is proposed in this spec PR:
webmachinelearning/webnn#676

To avoid breaking all uses of WebNN, this CL adds support for specifying
'shape' without removing support for 'dimensions'. Callers which pass
'dimensions' will see a console warning suggesting they update their
code to use 'shape'.

This CL was created primarily using targeted find-and-replaces,
followed by running git cl format. This CL has no behavioral changes,
other than the aforementioned logging.

Bug: 365813262
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I6b37ebc505a37686709f006b3ecafcefd3e2016d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502631
Reviewed-by: Reilly Grant <reillygchromium.org>
Commit-Queue: Austin Sullivan <asullychromium.org>
Cr-Commit-Position: refs/heads/main{#1356886}

--

wpt-commits: 1aa1ed11f44b7d560d3debc4c16ba691da0aa594
wpt-pr: 48086

UltraBlame original commit: 07f0bc50e723e5fde447a9fbcb888a800f1cf186
  • Loading branch information
marco-c committed Sep 26, 2024
1 parent df746ed commit cceb0ba
Show file tree
Hide file tree
Showing 138 changed files with 4,628 additions and 16,833 deletions.
96 changes: 16 additions & 80 deletions testing/web-platform/tests/webnn/conformance_tests/abs.https.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,15 +214,11 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -291,15 +287,11 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -351,15 +343,11 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -428,15 +416,11 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -565,16 +549,12 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
24
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -717,16 +697,12 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
24
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -854,16 +830,12 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
24
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1001,16 +973,12 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
24
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1138,17 +1106,13 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
4
6
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1286,17 +1250,13 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
4
6
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1424,18 +1384,14 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
2
3
4
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1573,18 +1529,14 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
2
3
4
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1712,19 +1664,15 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
2
2
2
3
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -1862,19 +1810,15 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
2
2
2
3
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -2002,9 +1946,7 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
2
Expand All @@ -2013,9 +1955,7 @@ dimensions
1
3
]
'
dataType
'
:
'
float32
Expand Down Expand Up @@ -2153,9 +2093,7 @@ descriptor
'
:
{
'
dimensions
'
shape
:
[
2
Expand All @@ -2164,9 +2102,7 @@ dimensions
1
3
]
'
dataType
'
:
'
float32
Expand Down
Loading

0 comments on commit cceb0ba

Please sign in to comment.