Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text spotting and tests with new package names #514

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Oct 22, 2024

Summary

As of 18/10/2024, I updated the code for MapTextPipeline, DeepSolo and DPText-DETR so they all have their own namespaces.
This PR updates the MapReader code to reflect these changes.

Ultimiately this makes it possible to install all three text spotters at the same time!

Describe your changes

  • Update imports
  • Update tests

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/spot_text/deepsolo_runner.py 66.66% 2 Missing ⚠️
mapreader/spot_text/dptext_detr_runner.py 66.66% 2 Missing ⚠️
mapreader/spot_text/maptext_runner.py 71.42% 2 Missing ⚠️
Flag Coverage Δ
unittests 74.56% <84.61%> (+6.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
setup.py 0.00% <ø> (ø)
tests/test_text_spotting/test_deepsolo_runner.py 100.00% <100.00%> (ø)
tests/test_text_spotting/test_dptext_runner.py 100.00% <100.00%> (ø)
tests/test_text_spotting/test_maptext_runner.py 100.00% <100.00%> (ø)
mapreader/spot_text/deepsolo_runner.py 82.14% <66.66%> (+70.07%) ⬆️
mapreader/spot_text/dptext_detr_runner.py 89.55% <66.66%> (+80.85%) ⬆️
mapreader/spot_text/maptext_runner.py 82.75% <71.42%> (+71.09%) ⬆️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant