-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve show methods #511
Open
rwood-97
wants to merge
10
commits into
main
Choose a base branch
from
improve_show
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve show methods #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove old show function
…/scheduler/etc, refactoring train_core, update metrics dict and show_metrics functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we have some very basic "show" methods for veiwing results. This is good for a quick look but would be better if we had some more advanced tools for visualising our results as part of the MapReader library.
Fixes #341
Address #478 - removed the utils.py file from annotate
Describe your changes
images.py
,runner_base.py
andrec_runner_base.py
and addsexplore_xx
methods in each of these classes. Explore uses geopandas explore to create an interactive visualisation of results.check_georeferencing
method ot the runners as this is needed to ensure we can convert to geo coords and therefore use the explore methods.infer_coords_from_patches
method in images.py which uses patches to infer parent coords. This is for e.g. if you have loaded patches via theload_patches
method and only added patch metadata (e.g. predictions).classifier.py
- now instead oftrain_loss_epoch
andtrain_fscore_epoch
as the key for a dict, we have nested dict with keys oftrain
,val
, etc and then within that keys ofloss
,fscore
etc.plot_metrics
method, users now pass a list of metrics to plot (e.g. "loss", "fscore_micro", etc) and it will plot by default all phases. Can tell it just to plot for one phase by passing thephases
argument.Using the
show_patches
method:Using the
explore_patches
method:Using
explore_predictions
method (i.e. the equivalent toexplore_patches
but for text spotting):Checklist before assigning a reviewer (update as needed)
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.