Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper update to mention text spotting #450

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

kmcdono2
Copy link
Collaborator

@kmcdono2 kmcdono2 commented Jul 2, 2024

Summary

Added sentence to related work to mention briefly that MapReader now includes text spotting.

Describe your changes

N/A

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@kmcdono2 kmcdono2 requested a review from rwood-97 July 2, 2024 09:09
@kmcdono2 kmcdono2 added the paper label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (c6d078b) to head (6d68559).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   62.52%   62.43%   -0.09%     
==========================================
  Files          40       40              
  Lines        6780     6780              
==========================================
- Hits         4239     4233       -6     
- Misses       2541     2547       +6     
Flag Coverage Δ
unittests 62.43% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rwood-97 rwood-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a minor change for that paragraph but otherwise all good.

paper/paper.md Outdated Show resolved Hide resolved
@kmcdono2 kmcdono2 merged commit cfc90e7 into main Jul 3, 2024
6 checks passed
@kmcdono2 kmcdono2 deleted the katie-paper-final-read branch July 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants