Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev text spotting #435

Merged
merged 9 commits into from
Jul 5, 2024
Merged

Dev text spotting #435

merged 9 commits into from
Jul 5, 2024

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented May 16, 2024

Summary

This PR adds new developments to the text spotting code:

  • Adds deduplicate methods for removing overlapping polygons within a patch and also between patches
  • Add overlap option when creating patches
  • Adds Runner base class to remove repeated code in the two different runners.

Fixes #404
Fixes #405

Describe your changes

Describe changes/updates you have made to the code.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Update relevant docs
  • Add tests where possible
    Note: I haven't added tests for the deepsolo/dptext part because of installing detectron2, will make an issue about this

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 189 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (6f19e41) to head (1d76188).
Report is 12 commits behind head on main.

Files Patch % Lines
mapreader/spot_text/runner_base.py 0.00% 169 Missing ⚠️
mapreader/spot_text/deepsolo_runner.py 0.00% 10 Missing ⚠️
mapreader/spot_text/dptext_detr_runner.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   62.43%   62.69%   +0.25%     
==========================================
  Files          40       41       +1     
  Lines        6780     6757      -23     
==========================================
+ Hits         4233     4236       +3     
+ Misses       2547     2521      -26     
Flag Coverage Δ
unittests 62.69% <10.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwood-97 rwood-97 marked this pull request as ready for review July 5, 2024 09:48
@rwood-97 rwood-97 merged commit add823a into main Jul 5, 2024
7 checks passed
@rwood-97 rwood-97 deleted the dev_text_spotting branch July 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants