Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues list): Prevent race condition when adding a commnet or replying to an issue #16

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

mapra99
Copy link
Owner

@mapra99 mapra99 commented Jul 30, 2023

There was something happening sometimes when a new issue or comment was created.. the result wasn't being reflected directly on the screen. This seems to be happening because the browser was reloading automatically when the comment or issue was created, which is the default behavior when a form is submitted. Adding event.preventDefault() to the event handler kills this behavior.

Copy link
Contributor

@ImMPrada ImMPrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogogo!

@mapra99 mapra99 merged commit 587fa94 into main Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants