Addressed situation when assign_default_confidence() returns only dataframe with all NaN confidence values #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so here was the problem:
When the dataframe whose redundant rows had to be filtered out had all
NaN
values for confidence, the linesssom-py/src/sssom/util.py
Line 441 in 5502067
returned
df
= Empty dataframe and the entire source data frame =nan_df
.Due to this, the following line:
sssom-py/src/sssom/util.py
Line 447 in 5502067
result in
dfmax = {}
which is of typepandas.Series
. Hence the confusion.The correct way to handle this is simple adding an
if
statement:sssom-py/src/sssom/util.py
Lines 447 to 469 in ffa2109
I've added an explicit test and it passes. Fixes #546