-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support languages="all" parameter in localize function #136
Open
gilsousampbx
wants to merge
21
commits into
main
Choose a base branch
from
keep-languages-if-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienbd
force-pushed
the
keep-languages-if-all
branch
from
September 26, 2024 14:42
42fcafd
to
e90121f
Compare
Added PR description |
kienbd
changed the title
wip: Keep languages if all
Support languages="all" parameter in localize function
Sep 27, 2024
kienbd
force-pushed
the
keep-languages-if-all
branch
from
October 1, 2024 04:02
7295d5f
to
6da594a
Compare
kienbd
force-pushed
the
keep-languages-if-all
branch
from
October 2, 2024 08:58
fba66db
to
9181125
Compare
kienbd
force-pushed
the
keep-languages-if-all
branch
from
October 2, 2024 09:04
9181125
to
f76e60e
Compare
tercanfurkan
reviewed
Oct 3, 2024
tercanfurkan
reviewed
Oct 3, 2024
Co-authored-by: Ömer Furkan Tercan <[email protected]>
tercanfurkan
reviewed
Oct 3, 2024
tercanfurkan
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some optional suggestions but this LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles
languages=all
param forlocalize
function.Summary of changes:
languages=all
: returns original language name and all languages that:hidden_prefix
omitted from the property namekeep_every_language
tokeep_all_non_hidden_languages
for clarityExpected Result:
Logic flow: