Fix Examples signing when building on a real device #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volkdmitri
approved these changes
Mar 29, 2024
kried
approved these changes
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #4619 +/- ##
=======================================
Coverage 60.54% 60.54%
=======================================
Files 189 189
Lines 21297 21297
=======================================
Hits 12894 12894
Misses 8403 8403 |
azarovalex
added a commit
that referenced
this pull request
Apr 15, 2024
* Use camera options to calculate zoom for overview camera (#4593) * Use camera options to calculate zoom for overview camera * Create dependabot.yml Enable Dependabot version updates * Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump github/codeql-action from 2 to 3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Fixed the possible situation when the upcoming route leg is rendered above the active route leg (#4589) * Add the ability to set locale for top and bottom banner views (#4595) * Implement configurable waypoints in CarPlayDelegate * Update Tests/MapboxNavigationTests/CarPlayUtils.swift Co-authored-by: Nastassia Makaranka <[email protected]> * Update CHANGELOG.md Co-authored-by: Nastassia Makaranka <[email protected]> * Update dependencies (#4614) * vk/dependencies-update: bumped Directions to 2.12.0, Maps to 10.16.5. Now compatible with Turf 2.7.0. * vk/dependencies-update: CHANGELOG updated * vk/dependencies-update: bumped NN to v202; update cocoapods in gemfile to 1.14 * vk/dependencies-update: unit tests fix * Sync Package.resolved with last resolved dependencies * Update CHANGELOG.md * Sync CocoaPodsTest --------- Co-authored-by: Udumft <[email protected]> * Fix SystemSpeechSynthesizer related main thread hang on NavigationViewController creation (#4617) * Don't check if AVSpeechSynthesizer.isSpeaking when unmuting it * add changelog entry * Improve error handing in case of invalid route responses (#4618) * Improve error handing in case of invalid route responses * Fix the order in which delegate is notified about failed reroute attempt * Fix for old Swift compiler versions * Fixed project structure in Carthage integration * Added changelog entry * Fix Examples signing when building on a real device (#4619) * Fix Examples signing when building on a real device * Replace build phases with the new script in 3 test targets * Grant exec permissions to the script * Fix carplay background maneuver card * Fix method annotation and desctiption * Update changelog * Fix compile errors * Update breaking changes list * Update changelog * Update spelling * Fix spelling * Update CHANGELOG.md * Update NN and Maps (#4628) * Update NN and Maps * Update CHANGELOG.md * Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Nastassia Makaranka <[email protected]> Co-authored-by: Thibaud Lopez Schneider <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Udumft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a workaround for Xcode 15 beta bugs we added a post-build action that injected a Mapbox token in Info.plist.
Even though that fixed the build at the time, it corrupted the .ipa signature when building on a real device. Xcode already fixed the issue that prevented us from using a build phase for injecting the token, so I remove post-build scheme actions in favor of build-phases, which happen before the binary is signed.
Additionally script is extracted in a separate file and signing is switched to automatic for all targets.