Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demaion/build updates #5

Merged
merged 35 commits into from
May 6, 2024
Merged

Demaion/build updates #5

merged 35 commits into from
May 6, 2024

Conversation

ndemaio
Copy link
Collaborator

@ndemaio ndemaio commented May 6, 2024

Prominent features:

  • Restructured the README documentation and rewrote part of it
  • Got the C code in the package to build and run on Windows and Linux
  • Added a source package tarball and binary packages for Windows and Linux to repo root

Not covered:

  • Instructions in README don't cover Linux because that side of the build needs more testing
  • Binary Linux package tested locally but needs verification by another user
  • Binary Linux package MAY work on Mac as well but this hasn't been attempted at all
  • Linux-style Makefile builds the package but isn't covered by the README instructions as they're aimed at R users that interact with the package through RStudio or the R console

@ndemaio
Updated licence in package description to say GPL 3
8915877
@ndemaio
Updated package documentation dummy file
37954aa
@ndemaio
Deleted old package documentation dummy file
0e1118e
@ndemaio
Updated DESCRIPTION file slightly following a Note in devtools::check()
73845c6
@ndemaio
Added the @useDynLib tag to the package description script so the rel…
f7f8923 
…evant entry stays in NAMESPACE when roxygenising the package
@ndemaio
Handled the global file descriptor in RcompGeomete source files in a …
63897a1 
…way that agrees with gcc 11 (used to compile with gcc 9, but not anymore)
@ndemaio
Rebuilt the documentation markdown files
3fadeeb
@ndemaio
Added .vscode folder to .gitignore
a0d97c6
@ndemaio
Eliminated some warnings from devtools::check() that pointed towards …
5733d83 
…potential problems in the R code
@ndemaio
Fixed the automated test for R function delaunay(...) and added a few…
25955f2 
… more assertions (needs more cleanup)
@ndemaio
Updated README.md for installing on Windows
c8222b9
@ndemaio
Added some extensions to .gitignore
1848be5
@ndemaio
Added extension .tar.gz to .gitignore
215623d
@ndemaio
Removed linux binary from repo
f649743
@ndemaio
Replaced some unsafe print statements from C code
4e0a3c2
@ndemaio
Removed *.tar.gz from .gitignore
acbbc11
@ndemaio
Added the R package tarball to the repo
23818b9
@ndemaio
Moved the GPL licence file into the package folder
4238c7a
@ndemaio
Rebuilt the tarball
31524cc
@ndemaio
Initial rewrite of the README file
b9b7d67
@ndemaio
Modified the Makefile to get the source package tarball to build on L…
6ed1c86 
…inux
@ndemaio
Added a binary package build to the repo
4c2acd8
@ndemaio
Updated the readme to include installation from binary zip package (o…
1e66128 
…n Windows)
@ndemaio
Eliminated some C compiler warnings related to pointer casts
d81edfa
@ndemaio
Fixed some print statements in C code
2e84c44
@ndemaio
Refined a C print statement for better compatibility
922fed8
@ndemaio
Eliminated a note from devtools::check()
7946d30
@ndemaio
Rebuilt the packages for Windows
0f843df
@ndemaio
Switched the .registration to TRUE in the package description scripts…
5444568 
… in an attempt to get the C code included
@ndemaio
Removed an fclose that was causing crashes on Linux
82f6539
@ndemaio ndemaio requested a review from tretherington May 6, 2024 05:01
tretherington
tretherington approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@tretherington tretherington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested it!

@tretherington tretherington merged commit 2fc2e00 into master May 6, 2024
1 check passed
@tretherington tretherington deleted the demaion/build_updates branch May 6, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tretherington tretherington tretherington approved these changes

Assignees

@tretherington tretherington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndemaio @tretherington