pv1000.xml: Added sixteen working homebrew cartridges #12801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New working software list additions: ---------------------------------------- Aerial [Inufuto] Antair [Inufuto] Ascend [Inufuto] Battlot [Inufuto] Bootskell [Inufuto] Cacorm [Inufuto] Cavit [Inufuto] Cracky [Inufuto] Guntus [Inufuto] Hopman [Inufuto] Lift [Inufuto] Mazy [Inufuto] Neuras [Inufuto] Osotos [Inufuto] Ruptus [Inufuto] Yewdow [Inufuto]
cuavas
requested changes
Sep 22, 2024
There was a problem hiding this comment.
- Please capitalise the titles the way Inufuto does on his web site: http://inufuto.web.fc2.com/8bit/
- Don’t bother with the
offsetattribute when all the cartridges in the software list only have a single ROM (and if you do need it, put it next to the size to make reading the XML easier).
hash/pv1000.xml
Outdated
Comment on lines
197
to
206
| <software name="antair"> | ||
| <description>Antair</description> | ||
| <year>2024</year> | ||
| <publisher>Inufuto</publisher> | ||
| <part name="cart" interface="pv1000_cart"> | ||
| <dataarea name="rom" size = "0x4000"> | ||
| <rom name="antiair.rom" size="0x4000" crc="1478db1a" sha1="b0c640776dcdb79db8a7cc8b2387a443182e1036" offset="0"/> | ||
| </dataarea> | ||
| </part> | ||
| </software> |
There was a problem hiding this comment.
This is supposed to be AntiAir: http://inufuto.web.fc2.com/8bit/antiair/
There was a problem hiding this comment.
romset ID should also be antiair, for consistency with coleco_homebrew.xml
Line 72 in bfb41f8
cuavas
changed the title
One Question: on Inufuto's website Aerial is labeled as AERIAL, but in coleco_homebrew.xml it's Aerial, which one should be used? |
|
I'm a little confused about this request to be honest. I thought we decided long ago that we weren't calling things like Pac-Man PAC-MAN just because that's what it shows. |
Also remove unnecessary offset attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New working software list additions:
Aerial [Inufuto]
AntiAir [Inufuto]
Ascend [Inufuto]
Battlot [Inufuto]
Bootskell [Inufuto]
Cacorm [Inufuto]
Cavit [Inufuto]
Cracky [Inufuto]
Guntus [Inufuto]
Hopman [Inufuto]
Lift [Inufuto]
Mazy [Inufuto]
Neuras [Inufuto]
Osotos [Inufuto]
Ruptus [Inufuto]
Yewdow [Inufuto]