Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPS challenge completed #256

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

KevinByrne
Copy link

Checkpoint added to align with user stories within challenge for Rock Paper Scissors - end of week challenge


get '/play' do
@name1 = $player_1.name
erb :play
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to play view, but erb file is play_game.erb which you'd already flagged.

@@ -0,0 +1,11 @@
<h1>Rock, Paper, Scissors</h1>
<hr>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible line break typo?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall structure looking like it's coming together nicely and following the principles of what we've covered aside of some potential tiny typos which you'd already flagged anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant