Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with horde upstream #3

Merged
merged 30 commits into from
Jun 5, 2024
Merged

Update with horde upstream #3

merged 30 commits into from
Jun 5, 2024

Conversation

boekhorstb1
Copy link

No description provided.

ralflang and others added 29 commits December 29, 2018 19:40
add transport_params hook for overriding Ingo_Transport params
@boekhorstb1 boekhorstb1 requested a review from midahp June 5, 2024 08:36
@boekhorstb1 boekhorstb1 self-assigned this Jun 5, 2024
Copy link

@midahp midahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your branch need a rebase first, so the diff here is readable

.horde.yml Outdated
license:
identifier: ASL
uri: http://www.horde.org/licenses/apache
dependencies:
required:
php: ^5.3 || ^7
pear:
pear.horde.org/horde: ^5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boekhorstb1 is your branch maybe not rebased correctly? For example I don't see these entries in the target branch: https://github.com/maintaina-com/ingo/blob/FRAMEWORK_6_0/.horde.yml

composer.json Outdated
"type": "pear",
"url": "https://pear.horde.org"
"type": "composer",
"url": "https://horde-satis.maintaina.com/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. I think your branch is not rebased correctly. Try to do this first

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks, ok will check

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repos diverged, I resolved the conflict in favor of upstream

@boekhorstb1 boekhorstb1 marked this pull request as ready for review June 5, 2024 09:48
@boekhorstb1 boekhorstb1 merged commit fa1e25c into maintaina-com:FRAMEWORK_6_0 Jun 5, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants