Propagate NavbarItem updates to NavigationBar #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshj01
commented
Apr 21, 2024
| @@ -191,17 +191,24 @@ class _NavbarRouterState extends State<NavbarRouter> | |||
| initialize(); | |||
| } | |||
|
|
|||
| void initialize({bool isUpdate = false}) { | |||
| void initialize() { | |||
| NavbarNotifier.length = widget.destinations.length; | |||
| for (int i = 0; i < NavbarNotifier.length; i++) { | |||
| final navbaritem = widget.destinations[i].navbarItem; | |||
| keys.add(GlobalKey<NavigatorState>()); | |||
There was a problem hiding this comment.
We are no longer reinitializing keys on update. I am quite not sure if this will be a problem if the navbar Items change. e.g if the number of items increeases or decreases.
There was a problem hiding this comment.
We can update navbar items on demand? What is the reason for this feature may I ask?
There was a problem hiding this comment.
Assume an app that allows users to acces app content without login and when the user logs in the the profile tab is shown.
e.g consider the tabs
Without login: home, explore, search
after login: home, explore, search , Profile
maheshj01
changed the title
Expose NavigationRail properties to NavbarDecoration
Co-authored-by: Mahesh Jamdade <[email protected]>
Support for badges on the NavbarItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to icon are now reflected
Pre-launch Checklist
///).flutter testIf you need help, consider pinging the maintainer @maheshmnj