Use query builder #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* Simplified the logic of fetching jobs from DB * Admin user can fetch all jobs of any user by setting special X-Dashboard-User header * Use ISO date format used by Grafana * Update and add new tests Signed-off-by: Mahendra Paipuri <[email protected]>
* We need to have time zone information to be able to convert times between unix and dateformats easily * Set SLURM_TIME_FORMAT env var for sacct command to include timezone in output * Include time stamps in BatchJob struct as we need them to generate Grafana URLs * Add env arg to os execute helpers to be able to set env vars to subprocesses * Update functions using Execute calls to include env vars arg Signed-off-by: Mahendra Paipuri <[email protected]>
* Grafana passes ISO time always in UTC zone * If we want to use local browser time, we need to use timestamp as query parameter * We simplify /api/jobs end point to accept timestamp as query parameter * Update tests and fixtures accordingly Signed-off-by: Mahendra Paipuri <[email protected]>
* Quoting SLURM_TIME_FORMAT is messing up DB entry format Signed-off-by: Mahendra Paipuri <[email protected]>
* Emit log in debug mode on how many rows deleted Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* Grafana expects a millisecond epoch for to and from query params Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* We are always returning 200 for all responses * Set correct response codes based on actual response * Update tests Signed-off-by: Mahendra Paipuri <[email protected]>
mahendrapaipuri
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchJobto set job start and end times in millisecond epochs. Grafana expectstoandfromin millisecond epochs