fix: Cannot read properties of null (reading length) in stream-shift #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is auto picked up by semver but does no harm so will merge |
|
Would be great if you could release this on npm so I can ask the Google team to upgrade |
|
Thank you! |
|
np |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue mafintosh/stream-shift#6 using https://www.npmjs.com/package/@google-cloud/storage. It has been resolved in mafintosh/stream-shift#7, would be great to get this merged. I'll open another PR on
@google-cloud/storageonce there's a new version. Thanks!