Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

Speed improvements #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Speed improvements #34

wants to merge 3 commits into from

Conversation

knifhen
Copy link

@knifhen knifhen commented Jun 19, 2014

Instead of using mvn to check if an artifact is present in the local repository I do it with ruby code. Build the path to the artifact in the local repository and if it's there, do a compare with the target file to see if they are the same.

This makes the maven resource much faster when working with artifacts that cannot be updated, i.e everything except snapshot versions.

…repository, just do a FileUtils.compare_file with the file in the local repo if present
@carlossg
Copy link
Member

carlossg commented Jul 8, 2014

the reason to use maven was to handle all the possible cases in the same way without reimplementing the fetcher, I'm not sure if your code would work with snapshots when they have the timestamped filename and not -SNAPSHOT

for example getting com.maestrodev.maestro.plugins:maestro-fog-plugin:1.19-SNAPSHOT from https://repo.maestrodev.com/archiva/repository/public-snapshots/

@knifhen
Copy link
Author

knifhen commented Aug 5, 2014

Timestamped snapshots should not be a problem, since the timestamp is not
present one the file has been downloaded by maven to the local .m2
repository.

//Regards Andreas Knifh

Best regards Andreas Knifh

On 8 July 2014 16:40, Carlos Sanchez [email protected] wrote:

the reason to use maven was to handle all the possible cases in the same
way without reimplementing the fetcher, I'm not sure if your code would
work with snapshots when they have the timestamped filename and not
-SNAPSHOT

for example getting
com.maestrodev.maestro.plugins:maestro-fog-plugin:1.19-SNAPSHOT from
https://repo.maestrodev.com/archiva/repository/public-snapshots/

Reply to this email directly or view it on GitHub
#34 (comment)
.

Denis Sitenkov and others added 2 commits December 4, 2014 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants