feat(BonsaiStorage): added new methods for retrieving key-value pairs and change id for BonsaiStorage
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 4, 2024 02:03
… skiping first 5 bites
Also updated `get_keys` to filter out non-leaf nodes + remove the length byte at index 0 when returning keys. > Please note that this currently poses problems with the implementation of `HashMapDb`, due to it not differenciating leaf nodes from branch nodes. This will have to be fixed at a later date.
AurelienFT
approved these changes
Apr 8, 2024
Can you create an issue with full context? And a proposal of fix? |
tdelabro
requested changes
Apr 9, 2024
tdelabro
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
This Pr aims to add functionality around key-value and change id retrieval for
BonsaiStrorage.What is the new behavior?
get_keysnow ignores empty keys and skips the size byte after the identifier. Note that this introduces issues with the handling ofHashMapDbas pertains toHashMapDBdoes not differenciate between leaf and branch nodes #26. Given that this is an error related to the structure and not this methods directly, I believe this update is still pertinent as it makes key retrieval more intuitive for the end user.get_key_value_pairshas been added which works pretty much as the name indicates, with the same drawbacks as stated above forget_keyswihthHashMapDb.get_latest_idhas been added which returns the latest id committed to a db, orNoneif no commit has occurred. This is mainly useful for creatingtransactional_statebased on the latest commit to the db.Does this introduce a breaking change?
Yes.
get_keyswill no longer:In practice though, this just means the function should now be easier to use.